FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3.02k stars 597 forks source link

Use inline image src for demo #949

Closed fritz-c closed 1 year ago

fritz-c commented 1 year ago

Description

The Chromatic UI tests in the CI, performing visual snapshot tests for the component, often snag on erroneous diffs caused by network issues when loading the sample slides from the demo site (example Chromatic run). This PR replaces the hosted image files with inline base64 representations of the same images, to be bundled in the site source code, hopefully avoiding the network flakiness issues.

Type of Change

CI-related

How Has This Been Tested?

I ran the cypress tests, checked the demo site locally, and everything checked out. The hope is that CI visual checks on future PRs will be more stable with this change.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuka-carousel ✅ Ready (Inspect) Visit Preview Aug 3, 2022 at 8:43PM (UTC)