fix: filter out null slides

ValGeorgiev commented 1 year ago

Description

When there is a condition to not render a particular slide, the library is rendering an empty slide. We need to filter out the null slides.

Fixes #951

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist

[ ] My code follows the style guidelines of this project (I have run pnpm run lint)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes (I have run pnpm run test:ci-with-server/pnpm run test)
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nuka-carousel	✅ Ready (Inspect)	Visit Preview	Aug 18, 2022 at 4:59PM (UTC)

fritz-c commented 1 year ago

This PR seems like a good candidate to add some tests. I've got a PR to fix the autoplay timing that introduces some integration tests using react-testing-library. If you don't mind waiting for that to get merged, maybe you can use that as a base for a simple integration test or two that makes sure slides are not rendered for null children.

FormidableLabs / nuka-carousel