FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3.02k stars 597 forks source link

Do not set "inert" for half visible slides #961

Closed mrsamse closed 1 year ago

mrsamse commented 1 year ago

Describe Your Environment What version of nuka-carousel are you using? 5.2.0 What version of React are you using? 18.0.0 What browser are you using? Chrome Version 103.0.5060.114

Is it possible to remove the "inert" tags on slides which are not completely visible? You can achieve this behaviour if you set the slidesToShow parameter to "1.5" and the cellAlign parameter to Alignment.Center. I want to add clickHandler on those slides, so that the user can also navigate by slide click.

I've produced a minimal reproduction at this codesandbox

fritz-c commented 1 year ago

Here's a minimal example of that working on v5.3.0 https://codesandbox.io/s/nuka-carousel-click-slide-to-change-example-spge74?file=/src/App.js

It appears the inert issue you mentioned was fixed in v5.3.0

mrsamse commented 1 year ago

Works with v5.3. Thanks!

rodrigovallades commented 5 months ago

Nope, it's not working in v7.0.0