search

FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.
https://commerce.nearform.com/open-source/nuka-carousel
Other
3k stars 596 forks source link

Rename dotNavigationIndices -> pagingDotsIndices to be more consistent with existing prop naming #968

Closed fritz-c closed 1 year ago

fritz-c commented 1 year ago

Description

I overlooked the existing naming of some props when I made the name for dotNavigationIndices. 

DefaultControlsConfig {
  // ...
  pagingDotsClassName?: string;
  pagingDotsContainerClassName?: string;
  pagingDotsStyle?: CSSProperties;

so I have renamed it to pagingDotsIndices for better consistency.

Type of Change

Refactoring; the code with the dotNavigationIndices feature was not yet released, so it is not a breaking change.

How Has This Been Tested?

The default components use the pagingDotsIndices internally, so it should be covered by our existing suite.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuka-carousel ✅ Ready (Inspect) Visit Preview Sep 9, 2022 at 8:15PM (UTC)