Set draggable=false on only children of the SliderList, not the whole document

[majgaard]

Description

Nuka Carousel currently applies its .slider-list img query selector to the entire document, rather than the narrower scope it ought to impact. In case of conflicting class names, Nuka Carousel may impact elements beyond its own scope.

Another less common reason:

I intend to use Nuka Carousel inside a React portal which portals its content into an <iframe /> element. Because my React code runs on the host window, libraries which access the global window & document end up impacting only the content outside the iframe. The motivation behind portaling into an iframe is to shelter my UI from undue influence from the host page it is embedded on (and shelter the host page from things my code may be doing). If I depend on libraries which access the global window or document, things will break ¯_(ツ)_/¯

Type of Change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

I ran the whole test suite, and also verified that the draggable=false attribute was being set on the demo carousel images.

Checklist

• [x] My code follows the style guidelines of this project (I have run pnpm run lint)
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes (I have run pnpm run test:ci-with-server/pnpm run test)
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [x] I have recorded any user-facing fixes or changes with pnpm changeset.
• [x] My changes generate no new warnings
• [ ] Any dependent changes have been merged and published in downstream modules

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nuka-carousel	✅ Ready (Inspect)	Visit Preview	Sep 22, 2022 at 3:25AM (UTC)

[fritz-c]

This fix is now available in v5.4.0. Thanks!