Fix the Alignment type so library users don't need to import an enum

FormidableLabs / nuka-carousel

Small, fast, and accessibility-first React carousel library with an easily customizable UI and behavior to fit your brand and site.

https://commerce.nearform.com/open-source/nuka-carousel

Other

3.06k stars 593 forks source link

Fix the Alignment type so library users don't need to import an enum #974

Closed fritz-c closed 2 years ago

fritz-c commented 2 years ago

Description

Changes the Alignment type used in cellAlign from an enum to a simple union of string literals so library users don't need to import the enum to use that prop.

I believe the original issue was a regression caused by some refactoring of the prop types I did, and the original user-facing type was a string literal union as well.

Fixes #973

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ensured the build worked normally.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nuka-carousel	✅ Ready (Inspect)	Visit Preview	Sep 26, 2022 at 2:59PM (UTC)