Fix: use forwardref for nullability

JeehyaeDance commented 1 year ago

Description

This PR is for "[v6] Expand ref type, use React.forwardRef #969". Wrapped carousel component with React.forwardRef and replaced innerRef prop with a native-to-React ref prop.

Fixes # 969 (issue)

Type of Change

[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project (I have run pnpm run lint)
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes (I have run pnpm run test:ci-with-server/pnpm run test)
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] I have recorded any user-facing fixes or changes with pnpm changeset.
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
nuka-carousel	✅ Ready (Inspect)	Visit Preview	Oct 27, 2022 at 5:25AM (UTC)

fritz-c commented 1 year ago

I only spotted a couple other breaking changes that had been proposed. There weren't any in GitHub issues, but there were a couple @deprecated-marked exports in the code that we could get rid of for v6.

FormidableLabs / nuka-carousel