search

FormidableLabs / prism-react-renderer

🖌️ Renders highlighted Prism output to React (+ theming & vendored Prism)
MIT License
1.88k stars 153 forks source link

feat: Add One Light and One Dark Themes #224

Closed mrousavy closed 1 year ago

mrousavy commented 1 year ago

fixes: https://github.com/FormidableLabs/prism-react-renderer/issues/218

gksander commented 1 year ago

Hi @mrousavy – thanks for contributing this. As an avid OneDark user, I really appreciate this 😄 I pulled down your branch and integrated the new themes into the demo, but most tokens seem to be getting colored with the hsl(220, 14%, 71%) line so things don't look quite right. I'm going to poke around a bit to see what it takes to get the additional colors in the right place.

image

gksander commented 1 year ago

Added a few tweaks to oneDark and oneLight:

image

image

And added a changeset record so we can release this into the wild once merged.

gksander commented 1 year ago

Okay, these changes should be live with version 2.1.0 🥳

mrousavy commented 1 year ago

Ah yeah I think I messed something up with the colors, my fault!!

I'll try with your changes in a second to double check if both themes look correct, orherwise I'll send another PR!

Thanks! :)