Closed karlhorky closed 9 months ago
@carbonrobot is this really completed? Where can we see the documentation of this feature?
This library is just a React extension for Prismjs to make the setup a little easier. At this time, we don't want to support anything custom over what prismjs does by default unless neccessary.
Ok, thanks for the reply. Maybe technically it should be closed as "Not planned" then.
Hey there! Would this project be open to instituting a fixed line-height (maybe configurable?) to make rendering across different fonts / browsers more consistent? Not sure how out of date the information is, but I've been reading some articles that
line-height: normal
is not the same across browsers. I would also find this useful to be able to position elements relative to each line more consistently.Prism has made the decision to use
line-height: 1.5
for all themes (Ref: PrismJS/prism#279).1.5
seems a bit excessive, especially with the more minimalMenlo
font-family
, which is the default used by the defaultcode-surfer
configuration. Prism usesConsolas
as the default when visiting the website on macOS, which both has a higher defaultline-height
(withline-height: normal
) and looks better like this.Below is a comparison of the following:
Header
: the defaultMenlo
withline-height: normal
(which resolves to1.2
in Chrome macOS)Header
: Prism's website, usingConsolas
andline-height: 1.5
For a further reference, HTML Boilerplate currently uses
1.4
.I am not actually all into this topic, so I may miss out on downsides or complexities involved in this.
cc @pomber