Closed LanF3usT closed 6 years ago
@LanF3usT -- Can you create a minimal repository with your source code plus all the necessary stuff to build and see this in action and then give us install + error reproduction steps? We can jump in and figure out what's going on. Thanks!
@ryan-roemer: I made an example with RunKit that represents my case without the userAgent
on the StyleRoot
component: https://runkit.com/lanf3ust/5a8e03a4b2d20f0012cafff2.
Seems related to inline style prefixing that was fixed in #962 (but not for keyframes).
Yeah, looks like inline-style-prefixer's Prefixer.prefixedKeyframes
is undefined if you pass in an invalid UA string (or if it can't detect one and a valid one isn't passed in, as I imagine the server behavior is).
https://github.com/FormidableLabs/radium/blob/master/src/prefixer.js#L127-L129
I expect we'd want to default to a value of keyframes
if it's undefined:
return getPrefixer(userAgent).prefixedKeyframes || 'keyframes';
As far as I can tell it works as expected on the client and if you pass in a valid UA or "all".
Thanks @alexlande ! I'm working on this now starting with regression tests.
:+1: Easiest way to see the incorrect behavior is to pass in a nonsense UA string in config.
I'm having an error with the
keyframes
method. When I try to use it, I get a@undefined
as return value in thestyle
definition.With the example:
The output for the
style
part is:When I add
<Radium.StyleRoot radiumConfig={{ userAgent: 'all' }}>
, it's worked again.