Closed cullenjett closed 5 years ago
maintainerd logging is enabled for this repository.
All actions related to rules and their enforcement will be logged here as a permanent record.
- `2017-07-31T03:38:01.138Z:effd109`: The pull request was created - `2017-07-31T03:40:38.862Z:effd109`: @cullenjett checked `I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/rapscallion/blob/master/CONTRIBUTE.md).`. - `2017-07-31T03:40:40.679Z:effd109`: @cullenjett checked `I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/rapscallion/blob/master/CONTRIBUTE.md).`. - `2017-07-31T03:40:43.871Z:effd109`: @cullenjett checked `All related documentation has been updated to reflect the changes made. _(required)_`. - `2017-07-31T03:40:46.897Z:effd109`: @cullenjett checked `My commit messages are cleaned up and ready to merge. _(required)_`. - `2017-07-31T03:40:48.086Z:effd109`: @cullenjett selected `patch` as the semantic version.
@divmain -- How are you feeling about this one? (LGTM)
Would close a recently opened issue.
@cullenjett I can merge this if you update with the latest master, please. Thanks!
Closed in favor of #124
While using
Renderer#toStream()
a console message from Bluebird is emitted regarding a promise created insrc/consumers/node-stream.js
that was not returned.Repro: Start a server that streams a response using
Renderer#toStream()
and observe the logs in the console. An example application where this behavior is happening can be found here.Versions:
Error Message:
(node:22461) Warning: a promise was created in a handler at my-repo/node_modules/rapscallion/lib/consumers/node-stream.js:43:9 but was not returned from it, see http://goo.gl/rRqMUw
Closes #119
The maintainers of this repo require that all pull request submitters adhere to the following:
The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following: