FormidableLabs / rapscallion

Asynchronous React VirtualDOM renderer for SSR.
MIT License
1.39k stars 50 forks source link

CircleCI 2 Support #126

Closed 88kami88 closed 5 years ago

88kami88 commented 5 years ago

In addition to migrating to CircleCI version 2.0, this PR also removes the publish step, as it was not working.-

Also sets up CircleCI workflows for future use.

Opting for manually publishes for the time being. I have verified my ability to publish and anyone else at Formidable should be able to in a pinch, as well.

@ryan-roemer


The maintainers of this repo require that all pull request submitters adhere to the following:

The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following:

88kami88 commented 5 years ago

Checks are redundant now that we're using workflows. Need to fix.

88kami88 commented 5 years ago

Checks resolved.

ryan-roemer commented 5 years ago

@ethersage -- Config changes and the actual builds kicked off look good. Nice work!!!

We do still have maintainerd operating, just without the ./deploy.sh script in gear. Let me know if you'd like me to disable that, or we can just keep it going as-is if it's working with our dev workflows.