fleg
commented
7 years ago rebased
Closed fleg closed 7 years ago
fleg
commented
7 years ago rebased
fleg
commented
7 years ago refactor attributes test, but it still needs review
fleg
commented
7 years ago rebased ping @divmain
divmain
commented
7 years ago Okay, I finally pulled this down. Thanks for all of your work on this! This is ready to go, from my perspective. There's a merge conflict, but as soon as that's fixed, this PR will be good to merge!
maintainerd[bot]
commented
7 years ago maintainerd logging is enabled for this repository.
All actions related to rules and their enforcement will be logged here as a permanent record.
- `2017-07-05T21:19:21.328Z:241bcec`: The pull request was created - `2017-07-05T21:19:36.046Z:241bcec`: @divmain selected `patch` as the semantic version. - `2017-07-06T06:38:38.372Z:c54d6c3`: @fleg checked `My commit messages are cleaned up and ready to merge. _(required)_`. - `2017-07-06T06:38:39.319Z:c54d6c3`: @fleg checked `All related documentation has been updated to reflect the changes made. _(required)_`. - `2017-07-06T06:38:39.651Z:c54d6c3`: @fleg checked `I have read and will comply with the [code of conduct](https://github.com/FormidableLabs/rapscallion/blob/master/CONTRIBUTE.md).`. - `2017-07-06T06:38:40.914Z:c54d6c3`: @fleg checked `I have read and will comply with the [contribution guidelines](https://github.com/FormidableLabs/rapscallion/blob/master/CONTRIBUTE.md).`.
fleg
commented
7 years ago rebased, ci fail looks unrelated
picked attributes tests from #58 and fixed all of it, I use more of react-dom internals to minimize copy&paste and difference in result
also closes #94
wip
The maintainers of this repo require that all pull request submitters adhere to the following:
The maintainers of this repository require you to select the semantic version type that the changes in this pull request represent. Please select one of the following: