Chore/browser tests - Githubissues

FormidableLabs / react-fast-compare

fastest deep equal comparison for React

MIT License

1.59k stars 54 forks source link

Chore/browser tests #10

Closed ryan-roemer closed 6 years ago

ryan-roemer commented 6 years ago

Status: Ready for review!

Refactor the test directory structure.
Imports the node tests into the browser, building with webpack. They are the source of truth.
Run headless chrome in Travis.
Run IE9 in Appveyor.
Use builder to parallelize running lint and various tests.
Fixes #7

Stuff left to do:

Code coverage: https://github.com/FormidableLabs/react-fast-compare/issues/11
Sauce labs for more coverage: https://github.com/FormidableLabs/react-fast-compare/issues/12

/cc @chrisbolin

chrisbolin commented 6 years ago

looks good. so let's just

fix yarn benchmark
document yarn test-node -- --watch

ryan-roemer commented 6 years ago

@chrisbolin -- I think I've addressed everything in: https://github.com/FormidableLabs/react-fast-compare/pull/10/commits/ee3946abd552934345b9bcc5b8e4024b7727c9ae

Also note that I've added npm version as our designated workflow because all our other projects do it and it's a good way to ensure the tests are run before publishing ;)

chrisbolin commented 6 years ago

🎉

ryan-roemer commented 6 years ago

@chrisbolin -- One last change: I realized we were emitting test bundles for each separate test file resulting in a lot of extra webpack work and execution duplication / slowness. Combined everything to one bundle and about halved the karma time (which makes sense since we currently have two separate test files): https://github.com/FormidableLabs/react-fast-compare/pull/10/commits/2cf5197d14f302767c49947e6b0c9eeb4d29dd33