use node 18 and clear pipeline warnings

FormidableLabs / react-fast-compare

fastest deep equal comparison for React

MIT License

1.59k stars 54 forks source link

use node 18 and clear pipeline warnings #134

Closed Burnett2k closed 7 months ago

Burnett2k commented 7 months ago

Description

As part of an internal Formidable Open Source audit, we're going through and updating some GH actions to no longer use unsupported versions of node. Also, removing them from our testing pipelines.

I also noticed we weren't utilizing a cache for yarn, so I added that into setup-node action to speed things up slightly.

Checklist:

[x] All tests are passing
[x] Type definitions, if updated, pass both test-ts-defs and test-ts-usage
[x] Benchmark performance has not significantly decreased
[x] Bundle size has not been significantly impacted
[x] The bundle size badge has been updated to reflect the new size

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: 4310e6eee5415d5f400b3a3525a445a32c719d5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.21%. Comparing base (01b5798) to head (ac2c4db).

:exclamation: Current head ac2c4db differs from pull request most recent head 4310e6e. Consider uploading reports for the commit 4310e6e to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #134 +/- ## ======================================= Coverage 98.21% 98.21% ======================================= Files 1 1 Lines 56 56 ======================================= Hits 55 55 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.