add isNaN check for numbers

FormidableLabs / react-fast-compare

fastest deep equal comparison for React

MIT License

1.59k stars 54 forks source link

add isNaN check for numbers #18

Closed marcelmokos closed 6 years ago

marcelmokos commented 6 years ago

in javascript NaN !== NaN but shallow equal should process this comparision as equal
without this change deeply nested trees with NaN, will always return not equal

chrisbolin commented 6 years ago

@marcelmokos thanks so much for the PR! our goal is to track and match the functionality of fast-deep-equal. In fact, they have just added NaN support in 2.0.1. We need to update to 2.0.1: https://github.com/FormidableLabs/react-fast-compare/issues/15. As such I'm going to close this PR and we will work to update our core to fast-deep-equal@2.0.1.

chrisbolin commented 6 years ago

thanks again for bringing this to our attention! it's fixed with react-fast-compare@2.0.0 (released a few hours ago)