fix react-native bug for DOM "Element" checking

FormidableLabs / react-fast-compare

fastest deep equal comparison for React

MIT License

1.59k stars 54 forks source link

fix react-native bug for DOM "Element" checking #39

Closed chrisbolin closed 5 years ago

chrisbolin commented 5 years ago

Fix for #38

pgom commented 5 years ago

💪

chrisbolin commented 5 years ago

Fix doesn't work on IE. I'm guessing Element is not a function on IE. It's probably easier to test on AppVeyor in CI than to get a VM with IE (not Edge!) up and running. Will do this now

pgom commented 5 years ago

What about just checking if typeof(Element) != undefined?

chrisbolin commented 5 years ago

nice when a theory works out. So Element is typeof "object" in IE. Will change this and retest