FormidableLabs / react-fast-compare

fastest deep equal comparison for React
MIT License
1.59k stars 54 forks source link

Feature: Add support for ES.next Set, Map, ArrayBuffer #51

Closed ryan-roemer closed 4 years ago

ryan-roemer commented 4 years ago

Infrastructure

ryan-roemer commented 4 years ago

IE test failures have been tracked to missing class support:

class MyMap extends Map {}

from upstream fast-deep-equals. Planning to ignore es6 tests in IE.

ryan-roemer commented 4 years ago

Update: We're now just failing at Appveyor with:

FAILED TESTS:
  advanced
    warnings
      basics usage
        ✖ never warns
          IE 11.0.0 (Windows 8.1.0.0)
        AssertionError: true === false
           at fail (test/browser/index.js:2472:3)
           at strictEqual (test/browser/index.js:2662:5)
           at Anonymous function (test/browser/index.js:63698:13)
           at Anonymous function (test/browser/index.js:63697:11)
           at Anonymous function (test/browser/index.js:63696:9)
    RegExp objects
      ✖ not equal RegExp objects (different flags)
        IE 11.0.0 (Windows 8.1.0.0)
      AssertionError: true === false
         at fail (test/browser/index.js:2472:3)
         at strictEqual (test/browser/index.js:2662:5)
         at Anonymous function (test/browser/index.js:63740:11)
[builder:finish] Hit 2 errors: 

It's the same failure, just in two different runs:

{
    description: 'not equal RegExp objects (different flags)',
    value1: /foo/,
    value2: /foo/i,
    equal: false
  }
ryan-roemer commented 4 years ago

FINALLY

Screen Shot 2019-12-19 at 3 09 43 PM

chrisbolin commented 4 years ago

thanks @ryan-roemer! finally getting to this now