fix: wrap preview in boundary

r281GQ commented 2 months ago

Description

React-Live did not catch a runtime error (not caught in the transpile phase).

We can't catch all errors (like event handlers) but we can catch useEffect's cleanup functions.

Fixes # (issue)

https://github.com/user-attachments/assets/7fa18a71-e688-406b-aa98-9f526518fa43

The above video demonstrates, not a cleanup function not causing crash.

Worth noting, cleanup function runs one cycle "behind", therefore even if we correct the code the previous code with error still shows up.

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

[ ] I have included a changeset if this change will require a version change to one of the packages.
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have run all builds, tests, and linting and all checks pass
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-live-docs-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 19, 2024 10:31am

changeset-bot[bot] commented 2 months ago

⚠️ No Changeset found

Latest commit: a0d276e6b3eb29a0ff3ceac90c0f6d4b40c91300

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

FormidableLabs / react-live