FormidableLabs / react-music

Make beats with React!
http://reactmusic.surge.sh
MIT License
2.72k stars 197 forks source link

Wrong notation for some notes #30

Closed neemzy closed 8 years ago

neemzy commented 8 years ago

Using a sawtooth synth for example, I need to use a2 in order to get an a3.

You can reproduce by setting up the bass line to Muse's Plug in Baby like I did:

<Synth
    type="sawtooth"
    steps={[
        [0, 2, "f#2"],
        [4, 2, "f#3"],
        [7, 1, "f#3"],
        [8, 2, "f#2"],
        [10, 2, "f#2"],
        [12, 2, "c#3"],
        [14, 2, "f#3"],

        [16, 2, "f#2"],
        [20, 2, "f#3"],
        [23, 1, "f#3"],
        [24, 2, "f#2"],
        [26, 2, "f#2"],
        [28, 2, "c#3"],
        [30, 2, "f#3"],

        [32, 2, "g2"],
        [36, 2, "g3"],
        [39, 1, "g3"],
        [40, 2, "g2"],
        [42, 2, "g2"],
        [44, 2, "d3"],
        [46, 2, "g3"],

        [48, 2, "g2"],
        [52, 2, "g3"],
        [55, 1, "g3"],
        [56, 2, "g2"],
        [58, 2, "g2"],
        [60, 2, "d3"],
        [62, 2, "g3"],

        [64, 2, "d2"],
        [68, 2, "d3"],
        [71, 1, "d3"],
        [72, 2, "d2"],
        [74, 2, "d2"],
        [76, 2, "a2"], // should be a3
        [78, 2, "d3"],

        [80, 2, "d2"],
        [84, 2, "d3"],
        [87, 1, "d3"],
        [88, 2, "d2"],
        [90, 2, "d2"],
        [92, 2, "a2"], // same here
        [94, 2, "d3"]
    ]}
/>
neemzy commented 8 years ago

Nevermind, I forgot octaves increment on C and not A.