search

FormidableLabs / react-music

Make beats with React!
http://reactmusic.surge.sh
MIT License
2.73k stars 196 forks source link

this.context.close is not a function #37

Closed giacomorebonato closed 7 years ago

giacomorebonato commented 7 years ago

I am trying to create a UI for React-Music. Sometimes (I can't understand not always) my component is unable to unmount because in the willUnmount event this.context.close is not a function.
Which could be the fix for this?

screen shot 2016-09-10 at 17 50 57
giacomorebonato commented 7 years ago

it should be this.audioContext.close() ... I am trying to understand why it is not like that in my node_modules

giacomorebonato commented 7 years ago

I have seen that the error is fixed in Master.
Usually in this situations I put the git url of the repo in the packages.json, but in this case it doesn't install anything... why?

jdan commented 7 years ago

Yep a fix for this is on master :) https://github.com/FormidableLabs/react-music/commit/54d2978d0beeb07a1a0be312f015242a0ae269c7

I also just tried to install with a github URL but it didn't work :(

kenwheeler commented 7 years ago

I'll get a release pushed

lfittl commented 7 years ago

@kenwheeler Just wanted to poke and see if there's an update on the release? (just ran into this as well)

An alternative would be to use the library through git, but somehow I couldn't get that to work.

giacomorebonato commented 7 years ago

Curious to know why it doesn't work through the git url... I have tried to fork the repo and to remove the .npmignore but the problem is not that.

kenwheeler commented 7 years ago

@lfittl sorry, was in israel. I'll get it pushed out today

kenwheeler commented 7 years ago

just pushed 1.0.2. holllllllaaaa