Open aalises opened 6 years ago
Hello! Thanks for this amazing project :musical_score: I have noted that in the effects file, the tunaJS bypass propTypes are set as propTypes.number. Shouldn't it be propTypes.bool? Test file of the tunaJS library where the bypass properties are assigned as booleans
Should we change the proptypes of the bypass property to be boolean, from number? Also, It would be nice to implement the Phaser effect (I used it a lot). I can make a pull request adding the phaser effect and correcting the propTypes today, WDYT?
Hello! Thanks for this amazing project :musical_score: I have noted that in the effects file, the tunaJS bypass propTypes are set as propTypes.number. Shouldn't it be propTypes.bool?
Test file of the tunaJS library where the bypass properties are assigned as booleans
Should we change the proptypes of the bypass property to be boolean, from number? Also, It would be nice to implement the Phaser effect (I used it a lot). I can make a pull request adding the phaser effect and correcting the propTypes today, WDYT?