FormidableLabs / react-native-ama

Accessibility as a First-Class Citizen with React Native AMA
https://commerce.nearform.com/open-source/react-native-ama/
MIT License
250 stars 16 forks source link

Add an Expo Example App to the project #135

Open JDMathew opened 1 year ago

JDMathew commented 1 year ago

This will allow users to run the example app without installing the project as well as test all packages with non-native dependencies

louiechristie commented 1 year ago

And put it in the app stores like the React Native Paper demo app on iOS and Android.

JDMathew commented 1 year ago

@louiechristie, we will make it available via Expo Go but may make it available in app stores if we need to extend functionality beyond the limits of Go

louiechristie commented 1 year ago

Link to previous similar conversation for the example app for react-native-paper library for reference.

There @RichardLindhout said "would be even nicer if we could have the app in the Play and App store with something like Fastlane! (like Flutter Gallery has)". @RichardLindhout reasons?

In my experience when I give someone who is new to React Native this Expo link on my resume/portfolio they never work out how to install it.

So if we are only going to only do an Expo Go example app for React Native AMA, (and not play/app store apps like React Native Paper iOS / Android and Flutter Gallery Android / Windows Store), then @kadikraman given you are now at Expo (congratulations by the way) perhaps you could influence Expo to improve the UX of this sort of page adding a mention that you have to install Expo Go app first? Or a clever deep link that installs Expo Go and the example app?

JDMathew commented 1 year ago

@louiechristie, thanks for the links to those conversations. I will bring it up with the team to extend beyond Expo Go. I agree scanning the QR is confusing if you don't have the Expo Go app and perhaps links should link to the app store with the Expo Go app if it's not installed on a users device. I don't see this being too complicated on Expo's end with deeplinking.

louiechristie commented 1 year ago

Fabulous, thanks @JDMathew ! 😀

kadikraman commented 1 year ago

Hey @louiechristie that's an excellent point. It does show you a link to download Expo Go, but only if you're viewing on a mobile browser. We could probably make it clearer on the website as well. Thanks for bringing it up 🙌