fix(ios): marshal booleans correctly (#999, #980)

FormidableLabs / react-native-app-auth

React native bridge for AppAuth - an SDK for communicating with OAuth2 providers

https://commerce.nearform.com/open-source/react-native-app-auth

MIT License

2.04k stars 441 forks source link

fix(ios): marshal booleans correctly (#999, #980) #1000

Closed shirakaba closed 4 months ago

shirakaba commented 4 months ago

Fixes #999 and #980

Description

Changes the method signatures from (BOOL *) (which marshals both true and false from JS to NO in Objective-C) to (BOOL) (which correctly marshals true to YES and false to NO).

Steps to verify

Set a breakpoint inside the iOS authorize method.
Confirm that useNonce = true from JavaScript now becomes YES instead of NO.

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 7d1a93e4f9d3f6d708d95a69b6a56d0ccaec24be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------------- | ----- | | react-native-app-auth | Major |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-app-auth	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 22, 2024 2:48am

sankar-gp commented 4 months ago

Could you let me know the approximate date for the publication of these changes and the release of the new version of the react-native-app-auth library?