fix: prefetch crash - Githubissues

FormidableLabs / react-native-app-auth

React native bridge for AppAuth - an SDK for communicating with OAuth2 providers

https://commerce.nearform.com/open-source/react-native-app-auth

MIT License

2.04k stars 441 forks source link

fix: prefetch crash #1010

Closed zibs closed 3 months ago

zibs commented 3 months ago

Fixes #478

Description

it was possible that the issuer could be an empty string ('') which would indeed cause the app to crash, since our invariant check missed that.

This is a required field, and the docs mention it, and the user must supply it in order for the functionality to work, but in the case that it's missed or forgotten, this is better than hard crashing as it was.

Steps to verify

before fix, set issuer: '', and see app hard crash
after fix, app doesn't hard crash

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-app-auth	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 30, 2024 9:45pm

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 3b15076938beddd936803abe750c5da406e898c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------------- | ----- | | react-native-app-auth | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR