FormidableLabs / react-native-app-auth

React native bridge for AppAuth - an SDK for communicating with OAuth2 providers
https://commerce.nearform.com/open-source/react-native-app-auth
MIT License
2k stars 438 forks source link

Bottom sheet modal overflows and content is missing on iOS 18.0.0 simulator. #1026

Open shonie2xx opened 3 days ago

shonie2xx commented 3 days ago

Issue

It seems the authorize method uses a modal, as the login page slides up from the bottom of the screen. On iOS 18.0.0, this modal is not displaying the content of the page and is not fitting within the screen. Below is a screenshot from the simulator:

simulator_screenshot_ABCB2A82-9ABC-4E83-A904-45FC72F0D22E

Environment

Simulator iOS: 18.0.0 Simulator Device: iPhone 15 Pro, iPhone 16 Pro Xcode: 16.0 macOS: Sequila 15.0 react-native: ^0.72.5 react-native-app-auth: 7.2.0 (also occurs on 8.0.0)

sasha-maliauka commented 3 days ago

We're having the same issue. Works fine on iOS 17.x.x/Xcode 15.x.x, not working on iOS 18/Xcode 16.

brampono commented 3 days ago

I can also reproduce this issue: Xcode: 16.0 Simulator: iPhone 16 Pro | iOS 18 react-native: 0.74.5 react-native-app-auth: 8.0.0

I can fix the issue by running simulator: iPhone 15 Pro | iOS 17.5

Seems like it could be an issue with iOS 18.0

ashosipyan commented 2 days ago

Have the same issue with Xcode16 and iOS18 simulator, the interesting thing is that it works in production build on real device.

Update: also tested dev build on real device and it's working as well