FormidableLabs / react-native-app-auth

React native bridge for AppAuth - an SDK for communicating with OAuth2 providers
https://commerce.nearform.com/open-source/react-native-app-auth
MIT License
2.04k stars 441 forks source link

useNonce, usePCKE, and prefersEphemeralSession always false on iOS (and Mac Catalyst) #999

Closed shirakaba closed 4 months ago

shirakaba commented 4 months ago

Issue

On iOS (and Mac Catalyst), for the authorize() function, all boolean values passed from JS (namely useNonce, usePCKE, and prefersEphemeralSession) are marshalled incorrectly into Objective-C.

The method signatures all specify (Bool *) instead of (Bool) (example), so React Native marshals both true and false (from JS) to NO (Obj-C).


Environment

This was noticed in this issue: https://github.com/FormidableLabs/react-native-app-auth/issues/980#issuecomment-2223008235