search

FormidableLabs / react-progressive-image

React component for progressive image loading
735 stars 61 forks source link

#10 Add noscript option to readme #23

Closed brybrophy closed 6 years ago

brybrophy commented 6 years ago

@boygirl This satisfies issue #10.

brybrophy commented 6 years ago

@boygirl I'm going to go ahead and close this PR. My other work has created some conflicts and I'm not really sure that this even belongs in the readme anyway. I just added it because it had a help wanted flag on the issue.

If you do want to include this info in the readme, let me know and I will make a new PR. I am planning on revamping the readme anyway.

boygirl commented 6 years ago

Thank for all your work on this project!

brybrophy commented 6 years ago

No problem. It’s a useful package that needs to be loved.

Do you think a scroll feature would be a good fit for this project? As in, the full image loads when the component is scrolled into the viewport. Part of me thinks yes, and part of me thinks using react-progressive-image in combination with a different scroll package would be a better fit.

Thoughts?