FormidableLabs / react-shuffle

Animated shuffling of child components on change
MIT License
250 stars 36 forks source link

React-native support, babel error #32

Closed ospfranco closed 6 years ago

ospfranco commented 7 years ago

Hey, I installed the library in a react-native application, however when I try to run it I get this error:

screen shot 2017-07-31 at 09 02 09

Is this because the library is not supporting react-native, or have I done something wrong?

ospfranco commented 7 years ago

Full packager output:


Looking for JS files in
   /Users/osp/dev/roombooking/mobile 

React packager ready.

Loading dependency graph, done.
transform[stderr]: Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
transform[stderr]: Warning: checkPropTypes has been moved to a separate package. Accessing React.checkPropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
transform[stderr]: Warning: React.createClass is no longer supported. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. (https://fb.me/migrating-from-react-create-class)
Bundling `index.ios.js`  75.5% (562/647), failed.
error: bundling failed: "TransformError: /Users/osp/dev/roombooking/mobile/node_modules/react-shuffle/index.js: [BABEL] /Users/osp/dev/roombooking/mobile/node_modules/react-shuffle/index.js: Unknown option: /Users/osp/dev/roombooking/mobile/node_modules/react/index.js.Children. Check out http://babeljs.io/docs/usage/options/ for more information about options.\n\nA common cause of this error is the presence of a configuration options object without the corresponding preset name. Example:\n\nInvalid:\n  `{ presets: [{option: value}] }`\nValid:\n  `{ presets: [['presetName', {option: value}]] }`\n\nFor more detailed information on preset configuration, please see http://babeljs.io/docs/plugins/#pluginpresets-options. (While processing preset: \"/Users/osp/dev/roombooking/mobile/node_modules/react/index.js\")"
error: bundling failed: "TransformError: /Users/osp/dev/roombooking/mobile/node_modules/react-shuffle/index.js: [BABEL] /Users/osp/dev/roombooking/mobile/node_modules/react-shuffle/index.js: Unknown option: /Users/osp/dev/roombooking/mobile/node_modules/react/index.js.Children. Check out http://babeljs.io/docs/usage/options/ for more information about options.\n\nA common cause of this error is the presence of a configuration options object without the corresponding preset name. Example:\n\nInvalid:\n  `{ presets: [{option: value}] }`\nValid:\n  `{ presets: [['presetName', {option: value}]] }`\n\nFor more detailed information on preset configuration, please see http://babeljs.io/docs/plugins/#pluginpresets-options. (While processing preset: \"/Users/osp/dev/roombooking/mobile/node_modules/react/index.js\")"
transform[stderr]: Warning: PropTypes has been moved to a separate package. Accessing React.PropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
transform[stderr]: Warning: checkPropTypes has been moved to a separate package. Accessing React.checkPropTypes is no longer supported and will be removed completely in React 16. Use the prop-types package on npm instead. (https://fb.me/migrating-from-react-proptypes)
transform[stderr]: Warning: React.createClass is no longer supported. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement. (https://fb.me/migrating-from-react-create-class)
Bundling `index.ios.js`  99.7% (607/608), failed.
error: bundling failed: "TransformError: /Users/osp/dev/roombooking/mobile/node_modules/react-shuffle/index.js: [BABEL] /Users/osp/dev/roombooking/mobile/node_modules/react-shuffle/index.js: Unknown option: /Users/osp/dev/roombooking/mobile/node_modules/react/index.js.Children. Check out http://babeljs.io/docs/usage/options/ for more information about options.\n\nA common cause of this error is the presence of a configuration options object without the corresponding preset name. Example:\n\nInvalid:\n  `{ presets: [{option: value}] }`\nValid:\n  `{ presets: [['presetName', {option: value}]] }`\n\nFor more detailed information on preset configuration, please see http://babeljs.io/docs/plugins/#pluginpresets-options. (While processing preset: \"/Users/osp/dev/roombooking/mobile/node_modules/```
ronal2do commented 7 years ago
isaachinman commented 6 years ago

+1

Assuming lack of response over 6 months means this lib does not support RN whatsoever.

Update: not sure who wrote this library but it seems the dependencies aren't structured correctly. After having to install two babel plugins myself to get the lib to work, I then found this codebase seems to be calling deprecated React methods (eg createClass) and is therefore totally unusable.

If this lib is deprecated, I would strongly suggest the maintainers add a note to the README to save people from wasting their time!

isaachinman commented 6 years ago

Final update: to any future visitors using RN, check out the built-in LayoutAnimation. Currently the docs are missing lots of info, but this article is helpful. Animates list reorders (or anything, really) in one line of code.

ospfranco commented 6 years ago

Seems latest commit was 2 years ago, deprecated library, closing this.