search

FormidableLabs / react-swipeable

React swipe event handler hook
https://commerce.nearform.com/open-source/react-swipeable
MIT License
2k stars 147 forks source link

Forward all non reserved props to child node. #214

Closed pcorpet closed 4 years ago

pcorpet commented 4 years ago

This allows to use any other div props without updating this lib again.

This change is Reviewable

hartzis commented 4 years ago

@pcorpet Howdy, thank you for the PR.

We just published v6 today(Nov 6) and the component, <Swipeable>, has been removed and we will only be supporting the hook moving forward useSwipeable.

We have a migration documentation on how to replace the component with the hook

📓 We additionally had another PR that addressed this concern before, #152

We decided against merging #152 as it would most likely require a major release. But the majority of the functionality could/should be able to be handled by an additional wrapping div element.

pcorpet commented 4 years ago

Perfect. I hadn't seen that. I'm migrating right away. thanks.