search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

Fragments: support for nested / (slash) under parent / (slash) #159

Closed kkerr1 closed 7 years ago

kkerr1 commented 7 years ago

Supports exact matching every time a non root level fragment is matching on forRoute="/". Added some more tests, but appreciate extra eyes on this. Addresses #154.

codecov-io commented 7 years ago

Codecov Report

Merging #159 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   99.55%   99.56%   +<.01%     
==========================================
  Files          20       20              
  Lines         227      229       +2     
==========================================
+ Hits          226      228       +2     
  Misses          1        1
Impacted Files Coverage Δ
src/components/fragment.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f6beea...5682a41. Read the comment docs.

tptee commented 7 years ago

Side note: I hate how angry and red "Changes requested" looks in reviews 😆

kkerr1 commented 7 years ago

Thanks for the careful review!

tptee commented 7 years ago

👏