search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

Link passes target to underlying <a> element #170

Closed Lucretiel closed 7 years ago

Lucretiel commented 7 years ago

Link now passes target to underlying element. Fixes #164

codecov-io commented 7 years ago

Codecov Report

Merging #170 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          20       20           
  Lines         229      229           
=======================================
  Hits          228      228           
  Misses          1        1
Impacted Files Coverage Δ
src/components/link.js 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a0ddf0...e6e6647. Read the comment docs.

tptee commented 7 years ago

Released in v13.1.3

Lucretiel commented 7 years ago

I just noticed that this project includes a dist in the repo. Should I have rebuilt as part of the PR, or will CI take care of that?

tptee commented 7 years ago

Don't worry, the version script builds dist on publish!