search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

Parsing the query string on location change #212

Open adregan opened 7 years ago

adregan commented 7 years ago

This PR is intended to fix #211.

Issue:

When navigating via the back button to a route which contains a query string, you will not receive a query object (parsed search string) in the payload.

Changes:

codecov[bot] commented 7 years ago

Codecov Report

Merging #212 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          19       19           
  Lines         253      253           
=======================================
  Hits          249      249           
  Misses          4        4
Impacted Files Coverage Δ
src/enhancer.js 94.11% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aa3297...b29ba43. Read the comment docs.

jahed commented 7 years ago

@tptee Are there any plans to merge this in? This is a pretty major bug.

Edit: I've tried this change out and it hasn't solved the problem for me. I'll keep looking.