search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

From router.enhancer to router.connect #216

Open villesau opened 7 years ago

villesau commented 7 years ago

fixes #215

This PR:

As the stores matchRoute function is not used anywhere, it's possible to get rid of it. When getting rid of it, the enhancer actually anymore just connects to the store so it shouldn't anymore be in the enhancer chain.

codecov[bot] commented 7 years ago

Codecov Report

Merging #216 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #216      +/-   ##
=========================================
- Coverage   98.41%   98.4%   -0.02%     
=========================================
  Files          19      19              
  Lines         253     250       -3     
=========================================
- Hits          249     246       -3     
  Misses          4       4
Impacted Files Coverage Δ
src/install.js 100% <ø> (ø) :arrow_up:
src/connector.js 92.85% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aa3297...8d9bf2f. Read the comment docs.

gouegd commented 7 years ago

That sounds good. I also suspect the enhancer is the reason the redux devtools don't work any more for me.

jcrben commented 6 years ago

@gouegd redux devtools seems to be working OK for me

gouegd commented 6 years ago

For me too now - or sometimes it gets stuck and I just reopen the debug tools. I don't think this comes from RFR at this point.