search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

Include POP action type as a public action type #218

Open pmeskers opened 7 years ago

pmeskers commented 7 years ago

This is a small PR which adds the POP (ROUTER_POP) action type to the public exports in src/index.js. Of all the types defined in src/types.js, this is the only one that was not included in the list of "public action types".

From what I can tell, it's quite useful since it's the only action which fires for both router induced back behavior (e.g., goBack()) and for browser induced back button (e.g., the browser's back button).

codecov[bot] commented 7 years ago

Codecov Report

Merging #218 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #218   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          19       19           
  Lines         253      253           
=======================================
  Hits          249      249           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6aa3297...34125ba. Read the comment docs.