Route gets basename strip out and breaks matching

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.

MIT License

1.04k stars 114 forks source link

Route gets basename strip out and breaks matching #229

Closed medeeiros closed 6 years ago

medeeiros commented 7 years ago

So I'm using basename /app and I have a route which is something like: /loans/:loanId/apply/start and redux-little-router will match as /loans/:loanId"ly"/start because /apply contains /app.

It's very easy to reproduce. Just have a basename which is not only / and use that anywhere in your router definition.

I'm using version 14.2.0

ZwaarContrast commented 6 years ago

Running into the same issue. Proposed pull request seems to fix this.

medeeiros commented 6 years ago

@aisapatino any progress on reviewing this?

tptee commented 6 years ago

Fixed in v14.2.3!