search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

Prevent basename from being replaced in the middle of the route #230

Closed medeeiros closed 6 years ago

medeeiros commented 7 years ago

Fixes #229

codecov[bot] commented 7 years ago

Codecov Report

Merging #230 into master will increase coverage by 0.36%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   98.89%   99.26%   +0.36%     
==========================================
  Files          20       20              
  Lines         271      271              
==========================================
+ Hits          268      269       +1     
+ Misses          3        2       -1
Impacted Files Coverage Δ
src/environment/browser-router.js 100% <100%> (ø) :arrow_up:
src/util/create-matcher.js 100% <0%> (+9.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5594f24...aa9f34f. Read the comment docs.

ZwaarContrast commented 6 years ago

Please implement this, running into this issue as well.

tptee commented 6 years ago

@aweary we can ignore codacy and bithound for now until we update deps