FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.

MIT License

1.04k stars 114 forks source link

Es output #247

Closed stefvhuynh closed 6 years ago

stefvhuynh commented 6 years ago

@ryan-roemer, @tptee, es build :)

codecov[bot] commented 6 years ago

Codecov Report

Merging #247 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   99.26%   99.26%           
=======================================
  Files          20       20           
  Lines         271      271           
=======================================
  Hits          269      269           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6165404...3825fe8. Read the comment docs.

stefvhuynh commented 6 years ago

@ryan-roemer, addressed comments

stefvhuynh commented 6 years ago

@ryan-roemer, could i get another quick review and a lgtm on this? thanks :)

ryan-roemer commented 6 years ago

@tptee -- What is this bitHound thing failing on? It says bitHound - Dependencies — 11 failing dependencies. as a red X, but the link says: https://www.bithound.io/github/FormidableLabs/redux-little-router/a999abc839d077e53f2475110f87dfae4ab5c453/dependencies/npm#filter-failing-dep

Can we either fix this or turn it off? (My motivation here is that having regularly failing CI things is super bad because folks start to ignore CI generally, even the important parts that work 😉 )

tptee commented 6 years ago

Removed bithound–nothing but a pain. Have been trying for about a year now to get rid of codacy...