search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

immutable support #248

Closed stefvhuynh closed 6 years ago

stefvhuynh commented 6 years ago

closes https://github.com/FormidableLabs/redux-little-router/pull/119 closes https://github.com/FormidableLabs/redux-little-router/issues/77

codecov[bot] commented 6 years ago

Codecov Report

Merging #248 into master will decrease coverage by 0.99%. The diff coverage is 97.95%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
- Coverage   99.26%   98.26%   -1%     
=======================================
  Files          20       20           
  Lines         271      289   +18     
=======================================
+ Hits          269      284   +15     
- Misses          2        5    +3
Impacted Files Coverage Δ
src/util/match-cache.js 100% <ø> (ø) :arrow_up:
src/util/generate-id.js 100% <ø> (ø) :arrow_up:
src/types.js 100% <ø> (ø) :arrow_up:
src/environment/hash-router.js 100% <100%> (ø) :arrow_up:
src/util/create-installer.js 100% <100%> (ø)
src/components/link.js 100% <100%> (ø) :arrow_up:
src/reducer.js 100% <100%> (ø) :arrow_up:
src/environment/express-router.js 100% <100%> (ø) :arrow_up:
src/components/fragment.js 97.82% <100%> (+0.04%) :arrow_up:
src/environment/hapi-router.js 100% <100%> (ø) :arrow_up:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6165404...1b56aed. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

Merging #248 into master will increase coverage by 0.17%. The diff coverage is 99.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   99.26%   99.43%   +0.17%     
==========================================
  Files          20       28       +8     
  Lines         271      355      +84     
==========================================
+ Hits          269      353      +84     
  Misses          2        2
Impacted Files Coverage Δ
src/types.js 100% <ø> (ø) :arrow_up:
src/util/generate-id.js 100% <ø> (ø) :arrow_up:
src/util/match-cache.js 100% <ø> (ø) :arrow_up:
src/immutable/util/immutable.js 100% <100%> (ø)
src/immutable/enhancer.js 100% <100%> (ø)
src/environment/express-router.js 100% <100%> (ø) :arrow_up:
src/components/link.js 100% <100%> (ø) :arrow_up:
src/enhancer.js 100% <100%> (ø) :arrow_up:
src/immutable/components/props-to-js.js 100% <100%> (ø)
src/util/throw-error.js 100% <100%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7085156...23ad2db. Read the comment docs.

stefvhuynh commented 6 years ago

@ryan-roemer, @tptee, PR is ready for review. Thanks! :D

stefvhuynh commented 6 years ago

@aweary, you might be interested in this PR as well if you are looking into immutable support in freactal.