FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 114 forks source link

[multibot] Add `sideEffects: false` to `package.json` #265

Closed ryan-roemer closed 6 years ago

ryan-roemer commented 6 years ago

webpack@4 / webpack@next will support package.json:sideEffects: false wherein libraries can indicate their ESM re-exports are side effect free and can be much more efficiently removed for smaller, faster final bundles.

Lodash has already rolled out this change in https://unpkg.com/lodash-es@4.17.5/package.json

Issues

This was originally uncovered / discussed at length in:

This PR should resolve the issues discussed in:

Changes

This PR has been automatically opened by your friendly multibot. The transform code and documentation is available at: https://github.com/FormidableLabs/multibot-examples/tree/master/transforms/webpack-side-effects

codecov[bot] commented 6 years ago

Codecov Report

Merging #265 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9b37e3...7fc9e4c. Read the comment docs.