search

FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.
MIT License
1.04k stars 113 forks source link

Publish TypeScript types along with package? #275

Closed jonasws closed 6 years ago

jonasws commented 6 years ago

The repository has a index.d.ts file, but this is not published along with the library code to NPM> Is this possible to change? Typings are, at the moment, available from DefinitelyTyped, but they are outdated, and it looks like the maintainers of said registry are pretty overwhelmed at the moment.

Maybe it would be a good thing to help them out and ship typedefs with the package itself?

parkerziegler commented 6 years ago

I'd definitely support this @tptee @ryan-roemer! Can take some time to do this if folks want to get me up to speed on our npm publishing process.

ryan-roemer commented 6 years ago

@parkerziegler -- Awesome. @tptee and/or I can definitely walk you through the publish process.

For this repo, I'm guessing:

$ npm version <major|minor|patch|ACTUAL_VERSION_NUMBER>
$ npm publish
$ git push && git push --tags

Also be sure to check with me before doing any of this that we have all the right permissions set up for you 😄

parkerziegler commented 6 years ago

Thanks @ryan-roemer! I'll ping you later today when I free up and we can coordinate 🚀

parkerziegler commented 6 years ago

@jonasws The TypeScript defs should now ship with the package as of v15.1.0. Let me know if you hit any issues with accessing the types. Closing this issue for now.