FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.

MIT License

1.04k stars 113 forks source link

Fix bug in `History` interface #289

Closed Viniter closed 5 years ago

Viniter commented 6 years ago

Fix History interface to be compatible with the @types/history one
history doesn't use Redux actions, action in this context is merely a string (either 'POST', 'POP' or 'REPLACE')
Fix issue #288

codecov[bot] commented 6 years ago

Codecov Report

Merging #289 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daf5d96...8db5288. Read the comment docs.

parkerziegler commented 5 years ago

@Viniter this looks good to merge! Would you mind rebasing your branch off latest master (it has only one additional commit, so should be fairly easy)? Ping me here and I'll merge it. Thanks for your contribution, I should be able to get this released with 15.1.2 this weekend at the latest.

parkerziegler commented 5 years ago

Updated branch via GitHub, merging now! Be on the lookout for v15.1.2 with these changes in the next few days. Thanks for your contribution, we really appreciate your help 🚀