FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.

MIT License

1.04k stars 113 forks source link

Make pathname optional in Typescript typings #295

Closed hisuwh closed 5 years ago

hisuwh commented 5 years ago

Pathname is optional in that you can do the following and it will work correctly:

dispatch(push({ query: { something: "value" }));

I've updated the typings to reflect this and to be inline with the typings that were previously available at @types/redux-little-router

codecov[bot] commented 5 years ago

Codecov Report

Merging #295 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57a15db...cb30678. Read the comment docs.

hisuwh commented 5 years ago

@tptee is anyone maintaining this repo any more? There are a number of useful pull requests sitting open

ryan-roemer commented 5 years ago

@tptee @parkerziegler -- Are either of you available to clear out this and the other short PRs like this one?

@boygirl -- If we can, would be wonderful to get a few folks perhaps also pitching in here as we really need the effort and I know Tyler is slammed with two projects at the same time right now. Thanks!

parkerziegler commented 5 years ago

@ryan-roemer I'm happy to take a look at this this afternoon. I can definitely do some redux-little-router work for Sauce but am also pretty slammed with full time client work.

parkerziegler commented 5 years ago

Thank you @hisuwh for the PR! Verified locally and am merging now. I'm going to take a look at additional type related PRs in this repo, get them onto master, and hopefully publish a patch release by beginning of next week with the updated index.d.ts.

ryan-roemer commented 5 years ago

Thanks @parkerziegler ! Mind doing the release too? 🙏

hisuwh commented 5 years ago

Thanks @parkerziegler Loving redux-little-router - glad you guys are still maintaining it

parkerziegler commented 5 years ago

15.1.2 is published! 🎉 Let us know if you have any issues!