FormidableLabs / redux-little-router

A tiny router for Redux that lets the URL do the talking.

MIT License

1.04k stars 113 forks source link

Include hash in stringify-href to allow hashes in new tabs/windows #299

Open Alex-Tideman opened 5 years ago

Alex-Tideman commented 5 years ago

When there is a hash in the href and a user right-clicks to open the link in the new tab, the hash isn't included in the url. This can be very hard for users to find what they are looking for if you rely on hashes to jump to content in a new tab.

codecov[bot] commented 5 years ago

Codecov Report

Merging #299 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5

Impacted Files	Coverage Δ
src/util/stringify-href.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff89966...863e87f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #299 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5

Impacted Files	Coverage Δ
src/util/stringify-href.js	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff89966...863e87f. Read the comment docs.

Alex-Tideman commented 5 years ago

@tptee Any chance we could get this in soon?

ryan-roemer commented 5 years ago

Hi @Alex-Tideman !

Thanks for the work! We're actually all super slammed this week and we're going to regroup next week for all things RLR-related.

Alex-Tideman commented 5 years ago

👍 No worries, thanks for the response! Appreciate all the hard work you guys do.

parkerziegler commented 5 years ago

Hey @Alex-Tideman! Thanks for the PR! As of December 10, 2018, this project is no longer under active maintenance and we will no longer be moving forward with issue requests. Thank you for helping to make redux-little-router better.