Sauce Labs: Status missed for `perTest` and `refreshClient`

FormidableLabs / rowdy

A small, rambunctious WD.js / WebdriverIO configuration wrapper.

MIT License

28 stars 9 forks source link

Sauce Labs: Status missed for `perTest` and `refreshClient` #22

Closed ryan-roemer closed 9 years ago

ryan-roemer commented 9 years ago

Need additional status setting in the following situations:

Config specifies perTest: true. Need status after each test.
Code call to adapter.refreshClient(). Need status after each call (this may be weird to set).

UPDATE: On thinking through this more, the most correct plan of action is probably:

Move all tracking of number of tests attempted / passed / failed into the client.
Flush that state and reset whenever a client is destroyed and do the sauce upload then.

ryan-roemer commented 9 years ago

@Maciek416 -- Just as a head's up, my guess is you'll want this bug resolved for eventual use in Sauce Labs land. It's not an issue currently if only one client (corresponding to a SL) session is spawned during a test, but is otherwise currently...

Maciek416 commented 9 years ago

Is this is to update sauce itself on success/failure?

ryan-roemer commented 9 years ago

Yes. Currently, if you set the adapter to spawn a new client on each test (beforeEach instead of before -- the "upload to sauce" status is lost).

There is a separate issue with doing per test client in that you're incurring a new SL session every test... But we could update status as an aggregating "they all pass at this point for all the clients I've seen so far" type thing...