Support sauce connect tunnel identifiers / Update Guacamole for Synchronous Operation

FormidableLabs / rowdy

A small, rambunctious WD.js / WebdriverIO configuration wrapper.

MIT License

28 stars 9 forks source link

Support sauce connect tunnel identifiers / Update Guacamole for Synchronous Operation #33

Closed Maciek416 closed 9 years ago

Maciek416 commented 9 years ago

This PR:

Has rowdy make use of SAUCE_CONNECT_TUNNEL_ID from the environment, if it exists. If supplied, rowdy will add tunnelIdentifier to all the sauceLabs desiredCapabilities objects found in the configuration.
Updates guacamole for synchronous operation update.
If using guacamole, use shrinkwrap. If the shrinkwrap load fails, try fetching synchronously from the SauceLabs API platform endpoint.

/cc @ryan-roemer

ryan-roemer commented 9 years ago

@Maciek416 -- Nice work! Have a refactor, then I'll re-review.

Also, can we test this option on Travis?

Maciek416 commented 9 years ago

Yes! I would very much like to test this on travis. I'll follow up with some test goodness in a bit.

Maciek416 commented 9 years ago

@ryan-roemer refactored code ready. Let's merge this and TODO the bigger tunnel thing

ryan-roemer commented 9 years ago

@Maciek416 -- Build is actually failing for at least eslint.

Maciek416 commented 9 years ago

Whoops! Safari's been crying wolf so often I wasn't looking closely. Lint fix added.

ryan-roemer commented 9 years ago

Error: [init({"name":"ryanroemer2@master","project":"Rowdy Tests","build":"111@d9d999050aa9f5aa8f3c19c0ebe65c9998052259","browserName":"safari","os":"OS X","os_version":"Mavericks"})] The environment you requested was unavailable.

:rage: