FormidableLabs / spectacle-boilerplate

[DEPRECATED] Boilerplate project for getting started with Spectacle Core
579 stars 192 forks source link

Rename or remove autoprefixer-core #18

Open ai opened 8 years ago

ai commented 8 years ago

autoprefixer-core was renamed to autoprefixer and old npm package was deprecated.

I tried to make a PR, but I didn’t find how you use autoprefixer-core.

ai commented 8 years ago

@kenwheeler I can send a PR if you told me where autoprefixer-core is used.

ai commented 8 years ago

Same thing with spectacle main repo.

/cc @knowbody

kenwheeler commented 8 years ago

I believe thats coming from Radium. Going to try to bump the version and see if that fixes it.

kenwheeler commented 8 years ago

Unless you want the PR. In which case, let me know and I'll merge it when it comes in.

ai commented 8 years ago

This type of investigation is not a good start in project for me :).

kenwheeler commented 8 years ago

Sorry for any inconvenience it caused you. It actually looks like you were the maintainer of autoprefixer-core? Oddly, I've used spectacle 3 times in the last two months and haven't hit this issue. When did you deprecate the package?

ai commented 8 years ago

We deprecated it 6 month ago. https://www.npmjs.com/package/autoprefixer-core

kenwheeler commented 8 years ago

I just cloned fresh and ran the project without a problem. Are you on npm2?

ai commented 8 years ago

@kenwheeler open a autoprefixer-core docs, it is deprecated ;).

ai commented 8 years ago

Also we should remove dependency from project, if nobody know where it is used ;)

kenwheeler commented 8 years ago

Ok, I suspect it had something to do with css-loader. I'll get this removed once I updated all the package versions and make sure its stable.

ai commented 8 years ago

css-loader uses PostCSS, but it has no Autoprefixer ;) https://github.com/webpack/css-loader/blob/master/package.json

kenwheeler commented 8 years ago

Did it used to?

kenwheeler commented 8 years ago

looks like pulling that dep out has no effect on the lib, so if you want to submit PRs to remove it, please do.

ai commented 8 years ago

Do it yourself :)

kenwheeler commented 8 years ago

Alright, you offered up above, so I didn't know if you wanted the credit for the find.

knowbody commented 8 years ago

@kenwheeler are you going to work on that, or do you want me to have a look into it?

edit: had to use the GH reaction for the first time, and it's on my own post lol