FormidableLabs / spectacle-boilerplate

[DEPRECATED] Boilerplate project for getting started with Spectacle Core
579 stars 192 forks source link

Does't not work out of the box #69

Closed svenliebig closed 6 years ago

svenliebig commented 6 years ago

I did a git clone yarn yarn start

and get this error on `localhost:3000

TypeError: Cannot read property 'props' of undefined Manager._renderSlide webpack:///node_modules/spectacle/es/components/manager.js:752 Manager.render webpack:///node_modules/spectacle/es/components/manager.js:838 finishClassComponent webpack:///node_modules/react-dom/cjs/react-dom.development.js:10249 updateClassComponent webpack:///node_modules/react-dom/cjs/react-dom.development.js:10226 beginWork webpack:///node_modules/react-dom/cjs/react-dom.development.js:10605 performUnitOfWork webpack:///node_modules/react-dom/cjs/react-dom.development.js:12573 workLoop webpack:///node_modules/react-dom/cjs/react-dom.development.js:12682 HTMLUnknownElement.callCallback webpack:///node_modules/react-dom/cjs/react-dom.development.js:1299 Object.invokeGuardedCallbackDev webpack:///node_modules/react-dom/cjs/react-dom.development.js:1338 invokeGuardedCallback webpack:///node_modules/react-dom/cjs/react-dom.development.js:1195

On Ubuntu 18.04.1 LTS 64bit with Google Chrome Version 69.0.3497.100

rdickert commented 6 years ago

Same for me. Works on spectacle 4.

git checkout be8cfa6 to get to the most recent working version.

EDIT: actually, you should set spectacle's version to at least ^4.0.4" if you want speaker notes to work. Spectacle went up to 4.4.1 before the switch to 5, so there may be other improvements available if they don't have 5 working when you read this.

ebrillhart commented 6 years ago

This should be working after a recent PR merge. Please reopen with new details if you're still having trouble. Thanks!