One-page: Pure ESM - Githubissues

ryan-roemer commented 1 year ago

Hey! What do you know? importmaps now mostly work! Which means we can update our browser one-page version to use just ESM.

Fixes:

Allow more tolerant react-syntax-highligher import behavior to better accommodate both CJS and ESM.

Notes:

No more UMD needed! 🎉
BUT, first load if not cached is 2010-era requirejs-in-dev-mode slow! 🐢
react* libs of course don't have ESM versions. And lots of other libraries don't play nice. So instead we use esm.sh which adjusts for ESM things
We have to manually override react to 18 (since some transitive deps bring in 17)

Future notes:

[ ] If this works we'll want to ticket out (1) removing UMD and (2) a major release.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
spectacle-docs-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2023 11:51pm

ryan-roemer commented 1 year ago

STATUS: Hold up. Something's rebroken with that prism import...

ryan-roemer commented 1 year ago

Oh, haha -- we need to publish my fix first for a preview to work. All good to review @carloskelly13 @gksander !

carloskelly13 commented 1 year ago

Hitting the local mjs build reveals your theme fix works!

FormidableLabs / spectacle