FormidableLabs / spectacle

A React-based library for creating sleek presentations using JSX syntax that gives you the ability to live demo your code.
https://commerce.nearform.com/open-source/spectacle/
MIT License
9.7k stars 690 forks source link

Fix inclusion of spectacle package.json for CLI #1307

Closed carloskelly13 closed 6 months ago

carloskelly13 commented 6 months ago

The CLI requires the package.json to correctly load the right dependencies. Since it was outside of the main source package for the CLI, it was not getting included, but looked correct locally. This uses a build script to copy the package in for packaging then remove after. Below are screenshots showing a local npm pack with the file included and the CLI working from what npm pack generated.

Screenshot 2023-12-18 at 1 49 18 PM Screenshot 2023-12-18 at 1 49 16 PM
vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 8:01pm